fix(build): .dockerignore not picked up #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the git context of the build-push-action ignores the .dockerignore because it is pulled by buildkit. Instead use checkout action and use the path context.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Apr 18, 2024
| @@ -165,7 +171,7 @@ jobs: | |||
| - name: Build and push Database Docker image | |||
| uses: docker/build-push-action@f2a1d5e99d037542a71f64918e516c093c6f3fc4 | |||
| with: | |||
| context: https://github.com/BerriAI/litellm.git#${{ github.event.inputs.commit_hash}} | |||
| context: . | |||
There was a problem hiding this comment.
this would break our releases - we need the context to pin to a commit hash
There was a problem hiding this comment.
Ah of course!
I added the commit hash input to the checkout step. I think this should be equivalent, but it is hard to test without actually running it.
|
@ishaan-jaff could you have a second look at this PR please? |
|
merging this - will take care of issues that come up |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2982 did not solve the issue, the files are still in the image builds.
Did some more research and found out that using the git context of the build-push-action ignores the .dockerignore because it is pulled by buildkit. Instead it is recommended to use the checkout action together with the path context.
See https://github.com/docker/build-push-action?tab=readme-ov-file#git-context and https://github.com/docker/build-push-action?tab=readme-ov-file#path-context.
Also see docker/build-push-action#655