Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Logfire Integration" #3637

Merged
merged 1 commit into from
May 15, 2024
Merged

Revert "Logfire Integration" #3637

merged 1 commit into from
May 15, 2024

Conversation

krrishdholakia
Copy link
Contributor

Reverts #3444

broke ci/cd:

  config: Config = outcome.get_result()
  File "/home/circleci/.local/lib/python3.9/site-packages/pluggy/_result.py", line 100, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/home/circleci/.local/lib/python3.9/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1067, in pytest_cmdline_parse
    self.parse(args)
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1354, in parse
    self._preparse(args, addopts=addopts)
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1237, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/home/circleci/.local/lib/python3.9/site-packages/pluggy/_manager.py", line 421, in load_setuptools_entrypoints
    plugin = ep.load()
  File "/usr/local/lib/python3.9/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 172, in exec_module
    exec(co, module.__dict__)
  File "/home/circleci/.local/lib/python3.9/site-packages/logfire/__init__.py", line 9, in <module>
    from ._internal.config import METRICS_PREFERRED_TEMPORALITY, ConsoleOptions, PydanticPlugin, configure
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 172, in exec_module
    exec(co, module.__dict__)
  File "/home/circleci/.local/lib/python3.9/site-packages/logfire/_internal/config.py", line 72, in <module>
    from .exporters.processor_wrapper import SpanProcessorWrapper
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 172, in exec_module
    exec(co, module.__dict__)
  File "/home/circleci/.local/lib/python3.9/site-packages/logfire/_internal/exporters/processor_wrapper.py", line 17, in <module>
    from ..scrubbing import Scrubber
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "/home/circleci/.local/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 172, in exec_module
    exec(co, module.__dict__)
  File "/home/circleci/.local/lib/python3.9/site-packages/logfire/_internal/scrubbing.py", line 70, in <module>
    class Scrubber:
  File "/home/circleci/.local/lib/python3.9/site-packages/logfire/_internal/scrubbing.py", line 90, in Scrubber
    SpanAttributes.SCHEMA_URL,
AttributeError: type object 'SpanAttributes' has no attribute 'SCHEMA_URL'

cc: @eslamkarim

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 0:39am

@krrishdholakia krrishdholakia merged commit 46a8152 into main May 15, 2024
4 checks passed
@krrishdholakia krrishdholakia deleted the revert-3444-main branch May 15, 2024 00:39
@krrishdholakia
Copy link
Contributor Author

Let's work on merging this back in once we have a release out

i suspect this has to do with the versioning of the logfire sdk @eslamkarim

@elisalimli
Copy link
Contributor

@krrishdholakia Tests for Logfire pass for me in local. Also, my local logfire SDK version (v0.29.0) is same as the CI/CD one.

Do the tests pass for you in local as well @krrishdholakia?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants