Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema.prisma): store model id + model group as part of spend logs allows precise model metrics #3789

Merged
merged 3 commits into from
May 23, 2024

Conversation

krrishdholakia
Copy link
Contributor

Title

store model id + model group as part of spend logs allows precise model metrics

Relevant issues

This fixes issues where model metrics on UI would show nothing, when the requests had been logged to spend logs. The issue was caused because the model string stored was the one returned by llm api (e.g. gpt-35-turbo), but this is not the one used by the user to filter their model groups (e.g. gpt-3.5-turbo)

Type

🐛 Bug Fix

Changes

  • updates schema.prisma with 'model_id' and 'model_group' in the spendlogs table

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

Validated via sql queries on db

Screenshot 2024-05-22 at 5 32 23 PM

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 1:22am

@krrishdholakia krrishdholakia merged commit 5a3aca1 into main May 23, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant