Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NMEA 4.10 TAG Blocks in aisnmea convenience library #1

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

simeonmiteff
Copy link
Contributor

Hi Bertold!

We recently worked with the go-nmea maintainers to get an earlier PR merged to add NMEA 4.10 TAG Blocks support: adrianmo/go-nmea#78

This PR adds support for:

  • Accessing the TAG Blocks info (which go-nmea now handles) via the aisnmea.VdmPacket struct (including some logic to merge tags from multi-sentence messages into one struct).
  • Encoding the values from the same struct into NMEA sentences (but only if they are not blank values, so if you don't touch that struct, you'll get un-tagged NMEA sentences, hence no change for existing applications that use go-ais)

I have added unit tests for the TAG Block processing code and two tests for checking that end-to-end decoding still works. The existing unit tests still pass, so I don't think this PR breaks anything.

Thanks for go-ais, and please let me know if you have any questions, concerns or desire any changes to get this PR accepted.

Regards,
Simeon.

@BertoldVdb BertoldVdb merged commit 7f7997d into BertoldVdb:master Oct 30, 2020
quartercastle pushed a commit to quartercastle/go-ais that referenced this pull request Jan 29, 2021
Add support for NMEA 4.10 TAG Blocks in aisnmea convenience library
BertoldVdb pushed a commit that referenced this pull request May 14, 2024
add a code-generated parser for Packets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants