Add support for NMEA 4.10 TAG Blocks in aisnmea convenience library #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Bertold!
We recently worked with the
go-nmea
maintainers to get an earlier PR merged to add NMEA 4.10 TAG Blocks support: adrianmo/go-nmea#78This PR adds support for:
go-nmea
now handles) via theaisnmea.VdmPacket
struct (including some logic to merge tags from multi-sentence messages into one struct).go-ais
)I have added unit tests for the TAG Block processing code and two tests for checking that end-to-end decoding still works. The existing unit tests still pass, so I don't think this PR breaks anything.
Thanks for
go-ais
, and please let me know if you have any questions, concerns or desire any changes to get this PR accepted.Regards,
Simeon.