Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework IPAM and fix concurrent IP race conditions #1030

Merged
merged 3 commits into from
May 20, 2024
Merged

Rework IPAM and fix concurrent IP race conditions #1030

merged 3 commits into from
May 20, 2024

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented May 20, 2024

Rework the inbuilt IPAM to prevent race conditions leading to the same IP being given out multiple times to different devices

closes #871

Copy link

netlify bot commented May 20, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 35a30e9
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/664b8f2a3a0a7f00081363ec

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 69.14894% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 23.45%. Comparing base (e45f056) to head (35a30e9).

Files Patch % Lines
pkg/roles/dhcp/ipam_internal.go 69.23% 20 Missing and 4 partials ⚠️
pkg/roles/dhcp/scopes.go 50.00% 2 Missing and 1 partial ⚠️
pkg/roles/dhcp/leases.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
+ Coverage   23.26%   23.45%   +0.18%     
==========================================
  Files         215      215              
  Lines       15617    15661      +44     
==========================================
+ Hits         3634     3673      +39     
- Misses      11555    11564       +9     
+ Partials      428      424       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 730b618 into main May 20, 2024
12 checks passed
@BeryJu BeryJu deleted the rework-ipam branch May 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP server hands out same IP when multiple clients connect simultaneously
1 participant