Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests & Fix CNAME support #1033

Merged
merged 3 commits into from
May 22, 2024
Merged

Improve tests & Fix CNAME support #1033

merged 3 commits into from
May 22, 2024

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented May 22, 2024

closes #838

CNAME support had been improved in etcd for a bit but this PR adds the same logic to the memory handler and dedupes a bunch of code

Also for tests, replaces the network communication with a much stricter direct query

Copy link

netlify bot commented May 22, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 94ee623
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/664e4040e121cf0008ea3a5d

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.18%. Comparing base (d11ac22) to head (94ee623).

Files Patch % Lines
pkg/roles/api/role.go 0.00% 2 Missing ⚠️
pkg/roles/dns/handler_etcd.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
- Coverage   23.51%   23.18%   -0.33%     
==========================================
  Files         215      214       -1     
  Lines       15661    15643      -18     
==========================================
- Hits         3682     3627      -55     
- Misses      11554    11590      +36     
- Partials      425      426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit aa4a519 into main May 22, 2024
11 of 12 checks passed
@BeryJu BeryJu deleted the improve-tests branch May 22, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS not always resolving
1 participant