Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/dhcp: document default DHCP option values #766

Merged
merged 3 commits into from
Nov 13, 2023
Merged

docs/dhcp: document default DHCP option values #766

merged 3 commits into from
Nov 13, 2023

Conversation

tigattack
Copy link
Contributor

@tigattack tigattack commented Nov 13, 2023

These are the defaults I discovered, let me know if I missed anything.

I chose not to document the default values for tagName router and tagName subnet since these are obvious based on the input fields in the scope config interface.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for beryju-gravity ready!

Name Link
🔨 Latest commit bb5bb5a
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/655222192671ef000826350e
😎 Deploy Preview https://deploy-preview-766--beryju-gravity.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 64
Accessibility: 88
Best Practices: 92
SEO: 77
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some other defaults:

  • Option 1 (subnet mask); set automatically based off of the CIDR of the scope
  • Option 51 (address lease time); set based off of the TTL of the scope

As with the other ones, these can also be overridden

@tigattack
Copy link
Contributor Author

Added options 1 & 51 in 41a12d4.

Co-authored-by: Jens L. <jens@beryju.org>
Signed-off-by: tigattack <10629864+tigattack@users.noreply.github.com>
@BeryJu BeryJu merged commit 97a74ca into BeryJu:main Nov 13, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants