Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly support CNAMEs #794

Merged
merged 4 commits into from
Nov 23, 2023
Merged

correctly support CNAMEs #794

merged 4 commits into from
Nov 23, 2023

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 22, 2023

closes #611

Also query for CNAME records when querying, and if any CNAME records are found, gravity will look those up too and return those too. The limit is hardcoded to 10 levels deep, which is more than should realistically be needed

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 43bf48c
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/655e9554d02aec0008c67e97

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35fe023) 57.77% compared to head (43bf48c) 57.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   57.77%   57.75%   -0.03%     
==========================================
  Files          90       90              
  Lines        4587     4587              
==========================================
- Hits         2650     2649       -1     
- Misses       1673     1674       +1     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 76262e2 into main Nov 23, 2023
10 of 12 checks passed
@BeryJu BeryJu deleted the dns/improve-cname branch November 23, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNAME records acting unlike how I would expect
1 participant