Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

播放进度条在没有播放歌曲或歌曲播放结束后不应该能被拖动 #19

Closed
pzhlkj6612 opened this issue May 1, 2019 · 0 comments
Labels
_UI-functionality 影响功能的界面问题。
Milestone

Comments

@pzhlkj6612
Copy link
Member

pzhlkj6612 commented May 1, 2019

在没有播放歌曲,或歌曲播放结束后, sliderSong 能被拖动,我认为这会让用户对它的功能感到疑惑,于是在 #15 版本中( 02b6fbb )做了一些修改:

AdjustingPos = false 时,一旦拖动 sliderSong ,其值就会被置为 void BottomWidget::onSliderSongPressed() 记录的 sliderSongOriginalPos ,使其表现为“无法被拖动”:

https://github.com/Beslyric-for-X/Beslyric-for-X/blob/02b6fbbb7cbed429faa1503f9514e90bf57a132f/BottomWidgets/BottomWidget.cpp#L311-L327


由于上述修改将导致在制作歌词时, sliderSong 被拖动或按住时会停止移动,释放后直接跳到当前播放位置这个问题, #16 版本( 354e203 )修改了相关逻辑, void BottomWidget::onSliderSongMoved(int position) 不再为 sliderSong 赋值,此时 void BottomWidget::onSliderSongPressed() 中第 324 行的注释已与功能不符:

https://github.com/Beslyric-for-X/Beslyric-for-X/blob/354e203e63fb05764e4c7280cdc14fafd516fbe2/BottomWidgets/BottomWidget.cpp#L319-L329


如果要做到“没有播放歌曲,或歌曲播放结束后, sliderSong 不能被拖动”,就需要先修复 #17 ,再做相关修改。具体的代码可能我之后写到评论里,或者直接开 PR 。

BensonLaur added a commit that referenced this issue Jul 13, 2019
…ther thread (同时不影响之前播放逻辑)

2、重新审视歌曲滚动条操作问题题问问题,确定最终逻辑为——在音频结束时禁用进度操作,在音频成功被载入时启用进度操作(除制作模式),一次解决 #19  #20 #21 提到的问题
@BensonLaur BensonLaur added the resolved-in-next-version The problem has been fixed or the requirement has been implemented label Jul 13, 2019
@pzhlkj6612 pzhlkj6612 added _UI-functionality 影响功能的界面问题。 and removed resolved-in-next-version The problem has been fixed or the requirement has been implemented labels Feb 23, 2020
@pzhlkj6612 pzhlkj6612 added this to the v3.1.1 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_UI-functionality 影响功能的界面问题。
Projects
None yet
Development

No branches or pull requests

2 participants