Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable streaming as XML #27

Merged
merged 6 commits into from
Sep 19, 2017
Merged

enable streaming as XML #27

merged 6 commits into from
Sep 19, 2017

Conversation

Flet
Copy link
Contributor

@Flet Flet commented Sep 18, 2017

  • refactored api.stream.service.js: moved JSON streaming to its own file

  • For xml format, the stream will return buffers, so each data chunk will be a buffer filled with exactly one object (example: <product><sku>123</sku></product>)

  • If streaming xml directly into a file, be sure to add the xml pragma and wrap the stream in a root element or it won't be valid.

  • xml format is not supported by the openBox endpoint

@coveralls
Copy link

coveralls commented Sep 18, 2017

Coverage Status

Coverage decreased (-3.03%) to 96.61% when pulling 15c8065 on stream-as-xml into fefc361 on master.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage decreased (-1.6%) to 98.045% when pulling cd95756 on stream-as-xml into fefc361 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.039% when pulling 25beee8 on stream-as-xml into fefc361 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage decreased (-1.6%) to 98.039% when pulling 25beee8 on stream-as-xml into fefc361 on master.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage increased (+0.08%) to 99.72% when pulling 07b943a on stream-as-xml into fefc361 on master.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage increased (+0.08%) to 99.72% when pulling 07b943a on stream-as-xml into fefc361 on master.

@Flet Flet merged commit 0b5b1af into master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants