NetBSD: setenv() missing

[0-wiz-0]

When building geeqie 2.2 on NetBSD, it fails with:

../src/exif-common.cc:780:3: error: 'setenv' was not declared in this scope; did you mean 'getenv'?

The problem here is that NetBSD (as Solaris, but different from e.g. Linux) removes symbols from headers when particular environments (like POSIX, or X/OPEN) are requested, and the file exif-common.cc defines _XOPEN_SOURCE (without a value) before including cstdlib.

The following patch fixes the problem on NetBSD:

--- src/exif-common.cc.orig     2024-01-26 13:57:52.740080922 +0000
+++ src/exif-common.cc
@@ -19,7 +19,7 @@
 
 #include <config.h>
 
-#define _XOPEN_SOURCE
+//#define _XOPEN_SOURCE
 
 #include <cmath>
 #include <cstdlib>

but I don't know why the symbol was defined in the first place and I expect there will be trouble on some other system.

If you know why it's set, you could limit the define to that system, e.g.

#ifdef __linux__ 
#define _XOPEN_SOURCE
#endif

which I think would be preferable.
If that's not an option, we could at least disable it on NetBSD:

#ifndef __NetBSD__
#define _XOPEN_SOURCE
#endif

Let me know what you think and I can prepare a PR - or just fix it :)

[caclark]

The original commit had the comment:
Unifying the datetime output
The output of %date% and %formatted.DateTime% should be equivalent.

But I have no idea....

#ifdef linux
#define _XOPEN_SOURCE
#endif

looks to be a safe option.