Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation for WotLK #187

Merged

Conversation

yannlugrin
Copy link
Contributor

This PR adds the french translation to make BeStride work on WotLK. Only locations existing in this extension are translated, no UI strings for now.

The flying mount in Krasus Area in Dalaran is at least fixed.

I didn't load the french translation file on the retail version as it is not completed. But I can add it if you want.

@yannlugrin yannlugrin mentioned this pull request Oct 22, 2022
Copy link
Collaborator

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will do a test tonight and will will merge if there are no issues.

@yannlugrin
Copy link
Contributor Author

@DanSheps I just fixed the translation file name, I didn't report it correctly when I did the PR. It's what happens when not committing from the working branch but using the web editor to create the PR 😅

@DanSheps DanSheps merged commit d46201e into Bestride:master Nov 3, 2022
@DanSheps
Copy link
Collaborator

DanSheps commented Nov 3, 2022

@yannlugrin Any chance this can be further developed for more localization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants