Add support for Evoker Hover ability #204
Conversation
There was a problem hiding this comment.
Thanks for the work.
I am almost ready to merge the latest code on my end that will make some major changes to the GUI itself. So i am going to mark this as needing changes. You may need to rebase at some point.
Question thought. Did you use Google Translate for the strings or did you pull them from somewhere else?
| { | ||
| {name="classes.evoker.hover",element="CheckBox",label=BeStride_Locale.Settings.Classes.Evoker.Hover,class="evoker"}, | ||
| }, |
There was a problem hiding this comment.
There is going to be a change to how options are done in the next version. I am going to hold off on merge until after that is completed.
There was a problem hiding this comment.
No problem on holding off. Feel free to reject this PR and add Hover yourself if you want, or I can update/remake it later after the GUI changes. I mostly did this to ensure I'd have hover for my Evoker starting today.
Also, I've got some code changes on my fork with support for Dragonriding. That is something I'd love to have in the addon on the 28th. Was waiting to PR those until after today's patch since that changed some API calls (again) in retail. Also, it may break WotLK/Classic support? Not sure, will have to see...will take a look at that this weekend maybe.
For the translations, a little bit of Google Translate, but for the spell/ability names and Evoker name, I used Wowhead and flipped between the different language versions of the site. Spell ids remain the same, so getting the name for the ability in-game is easy.
There was a problem hiding this comment.
I am to merge to master right now. If you want to get ahead of it, it is on develop and you can make the minor changes (I don't think it is anything too fancy so should be easy to do)
|
Going to merge this to develop and rework the options GUI |
No description provided.