Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically use STARTTLS based on port #46

Merged
merged 4 commits into from
Mar 10, 2021
Merged

Dynamically use STARTTLS based on port #46

merged 4 commits into from
Mar 10, 2021

Conversation

kaaax0815
Copy link
Contributor

Added if Statement to make STARTTLS work on port 587 and port 25

src/service/email.js Outdated Show resolved Hide resolved
src/service/email.js Outdated Show resolved Hide resolved
@BetaHuhn
Copy link
Owner

Now everything looks good, thanks!

Will merge this with the other PR this evening 👍

@BetaHuhn BetaHuhn changed the title STARTTLS Support Dynamically use STARTTLS based on port Mar 10, 2021
@BetaHuhn BetaHuhn changed the base branch from master to develop March 10, 2021 18:38
@BetaHuhn BetaHuhn merged commit a22a4f3 into BetaHuhn:develop Mar 10, 2021
@kaaax0815
Copy link
Contributor Author

How do you set these Emojis before the commit name? its kinda cool ngl

@kaaax0815 kaaax0815 deleted the STARTTLS branch March 10, 2021 18:49
@BetaHuhn
Copy link
Owner

In this (and most other of my repos) I use semantic releases with Gitmojis (that's what they are called :D). On every commit this GitHub Action runs and decides if it should bump the version based on those emojis.

I either use https://gitmoji.dev or a VS Code plugin to select them.

@kaaax0815
Copy link
Contributor Author

kaaax0815 commented Mar 10, 2021

Yes i mean why a emoji is on my commit lul. how this works. i hope i get better with such cool stuff on github as i age

@BetaHuhn
Copy link
Owner

I merged your changes with a squash and added the emoji when entering a title for the squash commit.

@kaaax0815
Copy link
Contributor Author

Oh okay and when you merge to master it makes a release because of the emoji you specified. i found them on your npm config page thingy as i looked through the .github folder. really cool

@BetaHuhn
Copy link
Owner

Yes, based on the emojis specified in the config, either a major, minor or patch release is created when I merge it into master.

It really saves a lot of time when you have multiple OS projects which constantly get small changes like dependency upgrades or small fixes.

@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kaaax0815
Copy link
Contributor Author

So your betahuhnbot is basicly hust the semantic release bot?

@BetaHuhn
Copy link
Owner

All my GitHub Actions use that account instead of the repos GITHUB_TOKEN. For one it looks better than having the name github-actions everywhere and it also makes it easier to grant access (or revoke it) to certain repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants