🐛 Don't crash while trying to parse a diff for binary files, fix #128 (…

…#242)
BetaHuhn · Aug 24, 2022 · ca2043b · ca2043b
1 parent e84bc1e
commit ca2043b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -21657,6 +21657,8 @@ class Git {
 		return `\n${ string }`.split('\ndiff --git').slice(1).reduce((resultDict, fileDiff) => {
 			const lines = fileDiff.split('\n')
 			const lastHeaderLineIndex = lines.findIndex((line) => line.startsWith('+++'))
+			if (lastHeaderLineIndex === -1) return resultDict // ignore binary files
+
 			const plainDiff = lines.slice(lastHeaderLineIndex + 1).join('\n').trim()
 			let filePath = ''
 			if (lines[lastHeaderLineIndex].startsWith('+++ b/')) { // every file except removed files

diff --git a/src/git.js b/src/git.js
@@ -160,6 +160,8 @@ class Git {
 		return `\n${ string }`.split('\ndiff --git').slice(1).reduce((resultDict, fileDiff) => {
 			const lines = fileDiff.split('\n')
 			const lastHeaderLineIndex = lines.findIndex((line) => line.startsWith('+++'))
+			if (lastHeaderLineIndex === -1) return resultDict // ignore binary files
+
 			const plainDiff = lines.slice(lastHeaderLineIndex + 1).join('\n').trim()
 			let filePath = ''
 			if (lines[lastHeaderLineIndex].startsWith('+++ b/')) { // every file except removed files