Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download breaks when using a relative path instead of a full url #357

Open
mprast opened this issue Sep 30, 2023 · 0 comments
Open

download breaks when using a relative path instead of a full url #357

mprast opened this issue Sep 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mprast
Copy link

mprast commented Sep 30, 2023

🐞 Describe the bug
As described in the docs, there are two ways to specify a space for spaces-cli to use when downloading a file. One is to use the -s command line option, and the other is to include it in the full download file url. The first path currently breaks with the error message 'Cannot read properties of null (reading 'includes')' . As far as I can tell this is coming from this line. Specifying a relative path instead of a full url causes the hostname to be undefined, which ends up blowing things up. The docs themselves provide a download example that uses a relative path, so I was expecting that to be supported.

📚 To Reproduce

try downloading just using a relative path

💡 Expected behavior

I should be able to use a relative path

🖼️ Screenshots

If applicable, add screenshots to help explain your problem.

⚙️ Environment

  • Version: 1.0.41
  • OS: fedora
  • Shell bash
@mprast mprast added the bug Something isn't working label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant