Include X-Vault-Request header on all requests #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steve-perkins Any chance you would have time to review this brief PR? |
|
@marc-szalkiewicz-dd Sorry. I left BetterCloud late last year, and no longer have access to do anything with this repo. My new employer uses Vault only via the Agent Injector in Kubernetes sidecars, so I haven't used the Java driver or been in the codebase in quite some time. There was a was a transition plan before I left, but that was pre-COVID. I don't know what the current situation is, and am not in ongoing contact. |
This was referenced Jan 30, 2021
|
For anyone needing this PR: I've forked this library and released a v6.0.0 version that is the same as the final BetterCloud/vault-java-driver 5.1.0, as well as a v6.1.0 version that includes the contents of this pull request: |
evan-ku
added a commit
to evan-ku/vault-java-driver
that referenced
this pull request
Mar 16, 2021
…setnt to Vault Agent Only needed if require_request_header = true is added in the vault-agent-config.hcl file. Reference: - https://www.vaultproject.io/api#the-x-vault-request-header - https://www.vaultproject.io/docs/agent#listener-stanza - BetterCloud#229 - ianferguson#3
evan-ku
added a commit
to evan-ku/vault-java-driver
that referenced
this pull request
Mar 16, 2021
…ort requests setnt to Vault Agent Only needed if require_request_header = true is added in the vault-agent-config.hcl file. Reference: - https://www.vaultproject.io/api#the-x-vault-request-header - https://www.vaultproject.io/docs/agent#listener-stanza - BetterCloud#229 - ianferguson#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault Agent (can) require consumers to include an
X-Vault-Requestheader to guard against some SSRF attacks for users of the Vault Agent, particularly in auto-auth mode: https://www.vaultproject.io/api#the-x-vault-request-headerThe hashicorp/vault Golang client adds this header to every outgoing request already: https://github.com/hashicorp/vault/pull/7627/files, this PR adds the same functionality to vault-java-driver