Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch API #1610

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fetch API #1610

merged 3 commits into from
Jun 15, 2023

Conversation

Strencher
Copy link
Member

@Strencher Strencher commented Apr 12, 2023

Adds BdApi.fetch() api which is equivalent design of the global fetch() api but it can bypass CSP. This also introduces the deprecation of require("https")/require("request") as well.

It also adds the ability to add a body to requests using current require("https") polyflll, reason being not much effort required to implement this.

@Strencher Strencher requested a review from rauenzi April 12, 2023 21:52
renderer/src/modules/api/index.js Outdated Show resolved Hide resolved
renderer/src/modules/api/fetch.js Outdated Show resolved Hide resolved
preload/src/api/https.js Show resolved Hide resolved
preload/src/api/fetch.js Outdated Show resolved Hide resolved
preload/src/api/fetch.js Outdated Show resolved Hide resolved
preload/src/api/fetch.js Show resolved Hide resolved
preload/src/api/fetch.js Show resolved Hide resolved
renderer/src/modules/api/fetch.js Outdated Show resolved Hide resolved
@rauenzi
Copy link
Member

rauenzi commented Apr 17, 2023

Could you also add the deprecation notices to the polyfill calls?

@Strencher Strencher requested a review from rauenzi May 1, 2023 19:40
@rauenzi
Copy link
Member

rauenzi commented May 2, 2023

@Diegiwg why?

@rauenzi rauenzi changed the base branch from main to development June 15, 2023 01:19
@rauenzi rauenzi merged commit fdc117e into development Jun 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants