Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hangs while downloading asar file #192

Closed
aspiers opened this issue Jul 22, 2021 · 20 comments · May be fixed by #282
Closed

hangs while downloading asar file #192

aspiers opened this issue Jul 22, 2021 · 20 comments · May be fixed by #282
Labels
bug Something isn't working

Comments

@aspiers
Copy link

aspiers commented Jul 22, 2021

Describe the bug

When using v1.0.0-hotfix installer, the install gets stuck on the "Downloading asar file" stage. My network traffic monitor shows virtually zero traffic on the network interface, so this isn't even a slow download issue like described in #191.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/BetterDiscord/Installer/releases
  2. Download https://github.com/BetterDiscord/Installer/releases/download/v1.0.0-hotfix/BetterDiscord-Linux.AppImage
  3. Run it
  4. Click through to the install process
  5. Observe it hanging on the "Downloading asar file" stage.

Expected behavior

The install proceeds and completes in a reasonable timeframe.

Screenshots

image

System Information:

  • OS: Linux (openSUSE Leap)
  • Discord Version: 0.0.15
@aspiers aspiers added the bug Something isn't working label Jul 22, 2021
@dav1312
Copy link
Contributor

dav1312 commented Jul 22, 2021

Duplicate of #35

@aspiers
Copy link
Author

aspiers commented Jul 22, 2021

I agree it looks like it's duplicate, but in practice it's not, because I don't have any antivirus or firewall software which could be blocking this.

@aspiers
Copy link
Author

aspiers commented Jul 22, 2021

I see from #173 that there is an issue with the use of phin for downloads, but #179 indicates that this issue only applies with non-hotfixed installers, whereas I see the problem with the hotfix. (Although weirdly I'm pretty sure the same hotfix installed has worked for me on two other machines running very similar openSUSE Linux distributions.)

I should also mention there's no issue with my network. It's a fast connection with pure fibre-optic end-to-end, provided by the most reliable ISP in the UK.

@Elepicos

This comment has been minimized.

@dav1312
Copy link
Contributor

dav1312 commented Jul 24, 2021

@Elepicos Is clearly not the same issue. The issue that you have is already pinned and closed #174

@Tropix126
Copy link
Member

Tropix126 commented Jul 24, 2021

Are there any visible errors in console? (You can access DevTools using Ctrl + Shift + I with the installer focused).

@aspiers
Copy link
Author

aspiers commented Jul 24, 2021

Nothing relevant, no. The only message which appears at all is

DevTools failed to load SourceMap: Could not load content for file:///tmp/.mount_BetterhbVtjk/resources/app.asar/renderer.js.map: 

which appears early on and is pretty obviously unrelated.

@QbDesu
Copy link
Contributor

QbDesu commented Jul 24, 2021

The installer being stuck on asar download is the same issue as before. The hotfix version didn't touch any of that, hence the original issues are still open.

@aspiers
Copy link
Author

aspiers commented Jul 24, 2021

Which original issues are those? I can't see any in this repo reporting the same thing.

@dav1312
Copy link
Contributor

dav1312 commented Jul 25, 2021

Issue #35 was closed by the user that posted it because it was fixed for him but the issue is still present.
It should still be open until it gets fully fixed in the next installer update because it was already fixed in Phin a few days ago ethanent/centra#12


Issue #179 is still open and it mentions 2 issues about Phin:

  1. This was already fixed in 384bef6. This is the one that is not a big issue after the hotfix.

    phin won't follow redirects by default which broke the download after the App repo was moved to the organization. This is a lesser problem, after the hotfix

  2. This one is the issue mentioned in New Installer Stuck on Downloading asar file. #35

    Phin has this nasty bug where it will never resolve/reject a promise when the server aborts the connection

@aspiers
Copy link
Author

aspiers commented Jul 25, 2021

Ah, those ones. As I mentioned above, #35 is not an exact duplicate of this - even though the symptom is the same problem, it has a different root cause (or at least contributing factor) since it was resolved after the user disabled their firewall and anti-virus.

I also mentioned above that #179 claims to apply only to the non-hotfixed installer, which I'm not using. I'm a little confused whether the followRedirects fix in 384bef6 is present in the non-hotfixed installer, or the hotfixed one, or both. It seems like an obviously beneficial change with no obvious downsides, so I'm not sure why it wouldn't be present in both. Is this a possible cause of the hang I am seeing in the hotfixed installer?

Regarding Phin failing to gracefully handle an aborted connection, I can understand that being a problem in some cases, but I don't see why my installer would be aborting the connection 100% of the time, so I'm guessing that is unrelated to my issue.

In summary, even though I'm aware of those known issues, I'm still no closer to knowing how to get past this hang. Some advice on solving that would be really appreciated. Thanks!

@dav1312
Copy link
Contributor

dav1312 commented Jul 25, 2021

I also mentioned above that #179 claims to apply only to the non-hotfixed installer, which I'm not using. I'm a little confused whether the followRedirects fix in 384bef6 is present in the non-hotfixed installer, or the hotfixed one, or both. It seems like an obviously beneficial change with no obvious downsides, so I'm not sure why it wouldn't be present in both. Is this a possible cause of the hang I am seeing in the hotfixed installer?

Even tho it claims to apply only to the non-hotfixed installer neither of the 2 issues mentioned are fixed in the hotfixed version.
Is just that the first issue is not a huge problem now in the hotfixed update.

If your connection is fine it could be related to issue #137

You can also try a manual installation
Or using betterdiscordctl

@aspiers
Copy link
Author

aspiers commented Jul 25, 2021

Thanks, betterdiscordctl looks like a great option!

@rauenzi
Copy link
Member

rauenzi commented Jul 28, 2021

I'm hoping to get a build out soon with the updated version of phin to see if this alleviates some of the download-hanging issues

QbDesu added a commit to QbDesu/Installer that referenced this issue Sep 2, 2021
dav1312 added a commit to dav1312/BetterDiscord-Installer that referenced this issue Sep 3, 2021
@ewertonurias
Copy link

I agree it looks like it's duplicate, but in practice it's not, because I don't have any antivirus or firewall software which could be blocking this.

I don't know if you already solved the problem, but I'm also an openSUSE Leap user, and I also had this problem, I opened YaST > Firewall > I disabled "Start at boot" and restarted the system. It worked for me.

@Gunstick
Copy link

Gunstick commented Jun 6, 2022

Problem still exists, so I installed with betterdiscordctl install

@KarsonTheFoxx
Copy link

I had this issue too, just re-launched the installer

@James-Livesey
Copy link

I got around this by killing Discord using killall Discord or killall DiscordPTB. I then re-launched the installer and it managed to install just fine. I think the download step might also be trying to kill the Discord process but is not able to, so killing it manually works.

@UnderscoreAngel
Copy link

apparently this happens because of issues with files and stuff, like creating directories, first is uninstalling betterdiscord if you tried installing it, then tweak the permissions of the installer allowing to run it as an executable and also allowing it to read and write, that's what worked with me, hope i help someone.

@tschallacka
Copy link

What fixed it for me was opening the console at the agreement window., check the disable cache checkbox under network, then continue the normal installer. Keeping the console open all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet