Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor preset for VSCodium #456

Merged
merged 1 commit into from Apr 18, 2020
Merged

Conversation

@jaredmoody
Copy link
Contributor

jaredmoody commented Mar 3, 2020

No description provided.

@RobinDaugherty
Copy link
Member

RobinDaugherty commented Mar 5, 2020

Thank you @jaredmoody! Have you been able to test that the URL structure works correctly? There was some feedback in #428 that I wasn't able to reproduce that looked like it might be caused by an extra leading slash in the file path (that's the only difference between the URL that we use for vscode and the one in that PR as far as I can see).

@RobinDaugherty RobinDaugherty added this to the v2.7 milestone Mar 5, 2020
@jaredmoody
Copy link
Contributor Author

jaredmoody commented Mar 5, 2020

Yes, I've been using this change myself and it works great with VSCodium - so works for me at least

@RobinDaugherty RobinDaugherty merged commit 7bdec95 into BetterErrors:master Apr 18, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jaredmoody jaredmoody deleted the Jetbuilt:vscodium branch Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.