Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks_version from the supported attributes #102

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Remove checks_version from the supported attributes #102

merged 3 commits into from
Jun 18, 2024

Conversation

gyfis
Copy link
Contributor

@gyfis gyfis commented Jun 18, 2024

No description provided.

@gyfis gyfis requested a review from PetrHeinz June 18, 2024 15:16
PetrHeinz
PetrHeinz approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@PetrHeinz PetrHeinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌 Do want to remove the checks_version, and keep only edge-based checks already? Didn't expect we'd be out of beta so soon. 🚀

You can generate the docs via make gen.

internal/provider/resource_monitor.go Outdated Show resolved Hide resolved
@PetrHeinz
Copy link
Contributor

I'd also suggest switching to VERSION := 0.11.0 in the Makefile and releasing it as v0.11.0 after merge.

@PetrHeinz PetrHeinz merged commit b781319 into master Jun 18, 2024
8 checks passed
@PetrHeinz PetrHeinz deleted the th/remove-the-checks-version-attribute branch June 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetrHeinz PetrHeinz PetrHeinz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gyfis @PetrHeinz