Correct type of policy_id in incoming_webhook
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the upstream documentation [0] and [1] the parameter for the escalation policy id shall be of type string not integer. The previous implementation could create resources fine but when running a plan of an existing resource it would fail with: ``` error: json: cannot unmarshal string into Go struct field incomingWebhook.data.attributes.policy_id of type int ``` This can easily be re-created by running terraform apply to create a incoming webhook resource with a escalation policy id and then running terraform plan as this will fail with the error message mentioned above. [0] https://betterstack.com/docs/uptime/api/create-incoming-webhook/ [1] https://betterstack.com/docs/uptime/api/incoming-webhooks-response-params/
|
Hi @adikus , is there something I can do to get this moving? Would love to finally deploy out the managing of the incoming web hooks in our infra. 🙏 |
|
Thanks @peter-hippo, finally got around to testing this - works great! |
|
This should be released as 0.3.17 in a bit |
|
No worries @adikus , thanks for work on the provider! 👏 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the upstream documentation [0] and [1] the parameter for the escalation policy id shall be of type string not integer. The previous implementation could create resources fine but when running a plan of an existing resource it would fail with:
This can easily be re-created by running terraform apply to create a incoming webhook resource with a escalation policy id and then running terraform plan as this will fail with the error message mentioned above.
[0] https://betterstack.com/docs/uptime/api/create-incoming-webhook/
[1] https://betterstack.com/docs/uptime/api/incoming-webhooks-response-params/