Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in tap current form. #1008

Closed
clyfe opened this issue Feb 2, 2021 · 2 comments
Closed

Built-in tap current form. #1008

clyfe opened this issue Feb 2, 2021 · 2 comments

Comments

@clyfe
Copy link

clyfe commented Feb 2, 2021

This ticket is for designing/approving a built-in tap current form calva.tapCurrentForm.
Alt+Shift+Enter seems to be free, I propose it as keybinding.

Should we have tap top level form?
Related: https://github.com/seancorfield/vscode-clover-setup/blob/develop/keybindings.json

@PEZ
Copy link
Collaborator

PEZ commented Feb 2, 2021

I agree. And probably we should have top level as well.

But let's ponder it all a bit...

Those args in the keybindings you link to intrigue me. If we create a tap command that takes arguments, and we make the same variables available to those arguments as we do with our current custom commands. Then we can bind keyboard shortcuts that tap anything we have defined variables for (and also code using the variables). We could then provide a few default shortcuts for obvious things like $current-form and $top-level-form. And the users can go crazy with it as well.

In fact we can take it a step further, I think... We can create a command that evaluates whatever args provided. And then provide default shortcuts with args like (tap> $current_form).

What'ya'think, @clyfe?

CC: @sauvala

@clyfe
Copy link
Author

clyfe commented Feb 2, 2021

Clover embeds sci, and correlates those args strings with functions in this little script here: https://github.com/seancorfield/vscode-clover-setup/blob/develop/config.cljs

On topic: yes I like the plan with the args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants