Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo gifs 404 in README on VisualStudio Marketplace #1018

Closed
jonoflayham opened this issue Feb 6, 2021 · 5 comments
Closed

Demo gifs 404 in README on VisualStudio Marketplace #1018

jonoflayham opened this issue Feb 6, 2021 · 5 comments

Comments

@jonoflayham
Copy link

jonoflayham commented Feb 6, 2021 •
edited
Loading

The excellent animated demo GIFs in the README aren't being rendered on Calva's VisualStudio Marketplace page, because there's still a reference to the master branch lurking somewhere.
@PEZ
Copy link
Collaborator

PEZ commented Feb 6, 2021

Oh, how strange. Investigating it now. Thanks for reporting!

@PEZ
Copy link
Collaborator

PEZ commented Feb 6, 2021

Seems there is a an option on vsce for this: microsoft/vscode-vsce#514

@jonoflayham
Copy link
Author

Ah, cool - makes sense. btw I noticed the URL for the Calva logo is absolute, and points to the dev branch.

@bpringe bpringe closed this as completed in f743c25 Feb 6, 2021
@PEZ
Copy link
Collaborator

PEZ commented Feb 6, 2021

Now works. Thanks again for the heads up, @jonoflayham !

@jonoflayham
Copy link
Author

Pleasure, @PEZ! I'm looking forward to using it, and thanks for the fantastic work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PEZ @jonoflayham