Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated namespaces not working #1060

Closed
brancusi opened this issue Mar 8, 2021 · 2 comments
Closed

Auto-generated namespaces not working #1060

brancusi opened this issue Mar 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@brancusi
Copy link
Contributor

brancusi commented Mar 8, 2021

Using the re-frame lein template.

Reproduce

  1. lein new re-frame test-app

Video overview

https://www.loom.com/share/4ed8d11315a14e28b4603eeb173ae799

System

  1. OSX 10.15.7
  2. VS Code 1.54.1

Thank you

@bpringe
Copy link
Member

bpringe commented Mar 9, 2021

Thanks for taking the time to report this and make the video. We probably should move to using the clojure-lsp feature for this.

@bpringe bpringe added the bug Something isn't working label Mar 9, 2021
@bpringe bpringe added this to To do in Brandon's Board via automation Mar 9, 2021
@bpringe
Copy link
Member

bpringe commented Mar 26, 2021

Hey @brancusi, would you mind trying out the VSIX from the linked PR and tell me if it solves your issue? https://12365-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.183-use-clojure-lsp-add-ns-feature-309fd169.vsix

I started to try to reproduce your issue, but the template that lein new re-frame <project> creates doesn't include a shadow-cljs.edn file (not sure if it should), so I was only jacked in and connected to a clj repl via lein, and I couldn't reproduce the issue with that and the current Calva code.

I still made a change to use clojure-lsp for this though, but rather than spend more time trying to replicate your situation I figured I'd see if you had time to test it.

@bpringe bpringe moved this from To do to In progress in Brandon's Board Mar 26, 2021
@bpringe bpringe closed this as completed in 309fd16 Apr 2, 2021
Brandon's Board automation moved this from In progress to Done Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants