Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clojure-lsp version configurable by the user #1088

Closed
PEZ opened this issue Mar 31, 2021 · 1 comment
Closed

Make clojure-lsp version configurable by the user #1088

PEZ opened this issue Mar 31, 2021 · 1 comment

Comments

@PEZ
Copy link
Collaborator

PEZ commented Mar 31, 2021

I know this could potentially cause us trouble, but deploying it hardcoded in the app can also cause us trouble. 馃槃

Besides, we do this with the jack-in dependencies.

@bpringe
Copy link
Member

bpringe commented Mar 31, 2021

Sounds good to me! Something like this has been on my radar, but I've waited to implement. What you did looks good. I had also implemented, at one time, a setting for the clojure-lsp path, so someone could download a version manually and set the path, but I abandoned that as I felt it was something additional to the change I was making, and wasn't sure it was what we wanted. I think lsp-mode allows this. But using a version setting seems to be about the same and easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants