Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jackInEnv per replConnectSequences #1124

Closed
rjerue opened this issue Apr 17, 2021 · 2 comments
Closed

Allow jackInEnv per replConnectSequences #1124

rjerue opened this issue Apr 17, 2021 · 2 comments

Comments

@rjerue
Copy link
Contributor

rjerue commented Apr 17, 2021

Hello,

Thanks for all the work you all do on Calva, it's a great tool to make Clojure more accessible to the masses!

Currently in Calva, if one wished to send an env var to their project. There is calva.jackInEnv which lets one specify a JSON Object with environment variables for all connect sequences. I'd like to propose an option that lets one set these per object in calva.replConnectSequences. I imagine a jackInEnv could be provided in there and the json objects could be merged in the style of {...global, ...customConnectJackIn} where the more specific entries override the global ones.

The use case that I have is that I have different REPL connect sequences for development vs. running unit tests (different lein profiles are used). Additionally. I have different env variables that need to be used. Typically, I go into the vscode settings.json and change them prior to deciding what connect sequence I will be running. I'd be nice to just set the specific overrides that I need for unit tests inside of it's REPL custom connect sequence.

@PEZ
Copy link
Collaborator

PEZ commented Apr 17, 2021

This issue makes perfect sense to me.

I imagine a jackInEnv could be provided in there and the json objects could be merged in the style of {...global, ...customConnectJackIn} where the more specific entries override the global ones.

I totally agree!

@bpringe
Copy link
Member

bpringe commented Jun 14, 2021

Closing this since #1142 was merged and released.

@bpringe bpringe closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants