Add stack frames to debugger call stack

[AL4AL]

I tried calva debugger in metabase project, wherever I pause the application by Instrumenting top level form for debugging, It pauses and everythinks works as expected but call stack, code is paused in a function and I know there are at least more than 3 files involved and many functions has called each other until they have reached this function but call stack only shows current function:

While I want to know who called this function

[bpringe]

Thanks for reporting this. I'm not sure if this is a limitation of cider-nrepl's debugger or just something I overlooked when implementing. I'll have to look more into it.

[bpringe]

It does indeed look like I just overlooked this 😄. I admittedly don't use the debugger much, so your feedback is helpful. I think I can improve the call stack fairly easily, though it may be a little time before I can complete this.

[bpringe]

I've noticed stacktraces don't have a source file for frame involving the call site. For example in the below image, if I eval the top level form at line 116, the frame for that call in the stacktrace will not have a source file.

I think this is because we're not passing file info to the nrepl eval op here:

calva/src/nrepl/index.ts

Line 307 in e4e20da

this.client.write(opMsg);

We pass the info to the eval function, but it's not used in the op. I think if we send that with the op then the stack traces will contain the info.

CC @PEZ. I'll try this out when I get back to this.

[bpringe]

You can see this in this stackframe here:

I eval'd the call to f in the image in the comment above at line 117, and you can see NO_SOURCE_FILE for that frame in the stacktrace in the output window. I hadn't really paid much attention to that before, but now it's needed to make the stacktraces work well with the debugger.

[bpringe]

My mistake, apparently we are sending line, column, and file to the nrepl op. I wonder why nrepl gives us NO_SOURCE_FILE for those frames then.

[bpringe]

A friend verified for me that in Cider this is also the case.

Calva:

Cider:

[bpringe]

@AL4AL Check out the latest version of Calva. You should see more stack frames in the call stack now. Let me know if you have issues.

[bpringe]

This was rolled back in 2.0.205. See #1236 and #1210.

The issue seems to caused by changes made to stackTraceRequest (see the changes in #1151), so this the place to look for a fix. I'll get back to this later, but in the meantime if anyone else wants to pick it up, please comment here so I know.