Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using the latest release of clojure-lsp #1248

Closed
PEZ opened this issue Aug 4, 2021 · 2 comments
Closed

Default to using the latest release of clojure-lsp #1248

PEZ opened this issue Aug 4, 2021 · 2 comments
Labels

Comments

@PEZ
Copy link
Collaborator

PEZ commented Aug 4, 2021

We should set things up such that Calva defaults to using the latest clojure-lsp release, rather than releasing new versions of Calva when clojure-lsp updates.

@bpringe
Copy link
Member

bpringe commented Aug 5, 2021

I've thought about this before, but my concern was that if any changes in clojure-lsp require a change in how Calva uses it for something to work correctly in Calva, then things can be broken by default, and will be (by default) until we act to fix it. I think it's similar to why we wouldn't want to auto-update libraries our code depends on (at least not major versions).

Hopefully this wouldn't happen often, though, especially since clojure-lsp has matured a lot, but I guess we'll try it out and see. 😄

@bpringe
Copy link
Member

bpringe commented Aug 5, 2021

There's also the option of letting the user opt-in to using the latest version always, so they accept anything that might break, rather than making it the default. 🤷‍♂️

@bpringe bpringe closed this as completed in b2557f5 Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants