Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait for clojure-lsp to initialize before activating nREPL lookup and navigation #1341

Closed
PEZ opened this issue Oct 15, 2021 · 1 comment
Closed

Don't wait for clojure-lsp to initialize before activating nREPL lookup and navigation #1341

PEZ opened this issue Oct 15, 2021 · 1 comment
Labels
code navigation lsp repl

Comments

@PEZ
Copy link
Collaborator

PEZ commented Oct 15, 2021 •
edited
Loading

Calva uses both clojure-lsp and nREPL for code navigation and definition lookup. This can be improved on, but generally works very well.

However, sometimes clojure-lsp takes a very long time to initialize in a project. Or it could be something preventing it from starting completely. (Which happened to me with a recent Calva update, the clojure-lsp download created a borked executable.) Then the dual setup with nREPL sharing similar tasks should be saving the day, right? Wrong. It seems like Calva is waiting for clojure-lsp to be done before it activates the dual wield.
@PEZ
Copy link
Collaborator Author

PEZ commented Oct 22, 2021

I don't think I had analyzed this problem correctly, but anyway, when we have an nrepl connection and it fails providing some service that clojure-lsp can provide, we should let clojure-lsp provide.

@PEZ PEZ mentioned this issue Oct 22, 2021
Merged
9 tasks
@PEZ PEZ closed this as completed Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code navigation lsp repl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ