Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select top level deref in comment #1346

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Fix select top level deref in comment #1346

merged 1 commit into from
Oct 17, 2021

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Oct 17, 2021

What has Changed?

cursor.backwardListOfType() now matches type towards the end of the opening bracket. Making a search for function name in a deref shorthand list @(function-name ...) work.

It might not be the right behaviour for when go backwards in a map from within a set, but I don't see when we would be doing that....

Fixes #1345

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • [ ] Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@PEZ PEZ merged commit ee1b956 into dev Oct 17, 2021
@PEZ PEZ deleted the 1345-top-level-deref branch October 17, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant