Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make alt+enter evaluate top level form also within line-comments #1549

Closed
PEZ opened this issue Feb 19, 2022 · 3 comments · Fixed by #1550
Closed

Make alt+enter evaluate top level form also within line-comments #1549

PEZ opened this issue Feb 19, 2022 · 3 comments · Fixed by #1550
Labels
editing evaluation

Comments

@PEZ
Copy link
Collaborator

PEZ commented Feb 19, 2022

Using alt+enter when the cursors is in a line comment currently performs comment continuation. This is by my design, but at least for me, a bad design. ...
@PEZ PEZ mentioned this issue Feb 19, 2022
Merged
13 tasks
@PEZ PEZ linked a pull request Feb 19, 2022 that will close this issue
Make alt enter always eval #1550
Merged
13 tasks
@PEZ
Copy link
Collaborator Author

PEZ commented Feb 20, 2022

Is it a Github bug that this issue is not closed by the merged PR linking it? WDYT, @bpringe ?

@PEZ PEZ closed this as completed Feb 21, 2022
@bpringe
Copy link
Member

bpringe commented Feb 23, 2022

I'm not sure... the note in the linked issues section says:

Successfully merging this pull request may close these issues.

Emphasis by me. I'd have to look more into it to know if that's a bug.

@PEZ
Copy link
Collaborator Author

PEZ commented Feb 23, 2022

I'm thinking ”may” is because the issue might be already closed. Anyway, I posted about this on their community forum: https://github.community/t/issues-which-a-linked-pr-is-supposed-to-close-does-not-close/230879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editing evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make alt enter always eval BetterThanTomorrow/calva
2 participants
@PEZ @bpringe