Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calva doesn't show action buttons in error message boxes #1949

Closed
PEZ opened this issue Nov 7, 2022 · 0 comments
Closed

Calva doesn't show action buttons in error message boxes #1949

PEZ opened this issue Nov 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@PEZ
Copy link
Collaborator

PEZ commented Nov 7, 2022

In places where the code uses vscode.window.showErrorMessage(msg, button1, button2, ...) in Calva, the message is shown without buttons.

This is due to:

We are not implementing the ”buttoned” signatures in our override:

https://github.com/BetterThanTomorrow/calva/blob/dc75fa67b517778fe406f1c07a3cbde897e637e1/src/overrides.ts#L1-L15
@PEZ PEZ added the bug Something isn't working label Nov 7, 2022
@PEZ PEZ mentioned this issue Nov 7, 2022
Merged
15 tasks
@bpringe bpringe closed this as completed in f9bff1d Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ