Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider completions not handling errors gracefully #2006

Closed
julienvincent opened this issue Jan 6, 2023 · 0 comments
Closed

Provider completions not handling errors gracefully #2006

julienvincent opened this issue Jan 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@julienvincent
Copy link
Contributor

The provider completions subsystem requests results from the lsp and nrepl providers sequentially and then merges the results together. If either of these providers fail to report completion items and throws an error then the entire flow fails.

Ideally if one of the providers is working and is able to report results then the completions should continue to work.

I ran into this while dealing with an obscure issue which was causing my nrepl-based completions to fail. This issue isn't reproducible on my setup anymore, however the above problem can be reproduced simply by stopping the LSP server (and leaving the nrepl connected). I would expect completions to continue to work if I have an active nrepl connection but have stopped the LSP.

The fix should be to simply handle provider response failures more gracefully. I have an incoming PR which addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants