Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out and fix which Calva settings should be scoped, and how #2083

Open
PEZ opened this issue Feb 16, 2023 · 0 comments
Open

Figure out and fix which Calva settings should be scoped, and how #2083

PEZ opened this issue Feb 16, 2023 · 0 comments
Labels
configuration ux User experience related

Comments

@PEZ
Copy link
Collaborator

PEZ commented Feb 16, 2023

From:

I noticed a problem with this setting, as well as almost all Calva settings, when testing this PR. I tested in a workspace where I had several root folders. When I have set a default for auto-selecting project type, that was used regardless of which folder I was jacking in to. Because I had set it with the Workspace settings... Trying to set it on Folder settings didn't work because we lack "scope": "resource" on the settings objects in the manifest. What's more. Even when I added that it still didn't work! Because we don't read folder settings... We should fix this. Connect Sequences and a lot of other settings make sense to add here. I think maybe all settings deserve this treatment. CC: @bpringe @julienvincent

For Calva to properly support using Workspace Folders we need to support the user scoping settings to a particular folder. I don't know for which settings this wouldn't make sense.

@PEZ PEZ added configuration ux User experience related labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration ux User experience related
Projects
None yet
Development

No branches or pull requests

1 participant