Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jack-in fails with version 2.0.337 #2113

Closed
cmaussan opened this issue Mar 15, 2023 · 9 comments · Fixed by #2115
Closed

Jack-in fails with version 2.0.337 #2113

cmaussan opened this issue Mar 15, 2023 · 9 comments · Fixed by #2115
Labels
jack-in regression Regression error

Comments

@cmaussan
Copy link

Jack-in is not working anymore, Calva can't connect to nREPL server whereas it is correctly launched.

; This is the Calva evaluation results output window.
; TIPS: The keyboard shortcut `ctrl+alt+o o` shows and focuses this window
;   when connected to a REPL session.
; Please see https://calva.io/output/ for more info.
; Happy coding! ♥️

; Jacking in...
; Connecting using "deps.edn" project type.
; You can make Calva auto-select this.
;   - See https://calva.io/connect-sequences/
; 
; Starting Jack-in Terminal: clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version,"1.0.0"},cider/cider-nrepl {:mvn/version,"0.28.5"}}}' -M:dev -m nrepl.cmdline --middleware "[cider.nrepl/cider-middleware]"
; Using host:port localhost:44071 ...
; Hooking up nREPL sessions ...
; Failed connecting.
; Jack-in done.
clj꞉undefined꞉>  ; Use `alt+enter` to evaluate

Downgrading to 2.0.336 fixes the issue.

@cmaussan
Copy link
Author

ctrl+c in pseudo terminal does not really kill the repl either. A ps launched in another terminal shows the repl still up.

@PEZ PEZ added jack-in regression Regression error labels Mar 15, 2023
@PEZ
Copy link
Collaborator

PEZ commented Mar 15, 2023

Thanks for reporting!

Some questions:

  • If you use the command Calva: Copy Jack-in Command Line to Clipboard and use that to start the repl and then connect Calva, does that work?
  • Can you reproduce this in a minimal project?
  • What OS are you using?

ctrl+c in pseudo terminal does not really kill the repl either. A ps launched in another terminal shows the repl still up.

Extra interesting, it was one of the things I thought I improved with this version. I just tried in a project here:

  1. After jack-in:
    % lsof -d cwd | grep 'java.*'"$PWD"                                   
    java      64431  pez  cwd    DIR   1,17      928 111060084 /Users/pez/Projects/poly-real-world
    % 
    
  2. ctrl+c in the jack-in terminal:
    % lsof -d cwd | grep 'java.*'"$PWD"                                   
    %
    

It might be that the two errors are related, of course.

@PEZ PEZ changed the title Impossible to connect to nREPL with last version 2.0.337 Jack-in fails with version 2.0.337 Mar 15, 2023
@cmaussan
Copy link
Author

  • I launched the repl by hand in a terminal and tried to connect to it with "connect to a running repl in your project" or "connect to a running repl, not in your project". Both did not work.
  • It was failing in all my clojure projects
  • Ubuntu 22.10
  1. After jack-in
$ lsof -d cwd | grep 'java.*'"$PWD"
java      15651         cmaussan  cwd       DIR  253,1     4096 12072379 /home/cmaussan/code/foo
  1. After ctrl+c in jack-in terminal
$ lsof -d cwd | grep 'java.*'"$PWD"
java      15651         cmaussan  cwd       DIR  253,1     4096 12072379 /home/cmaussan/code/foo

Hope that helps you.

@PEZ
Copy link
Collaborator

PEZ commented Mar 15, 2023

Thanks! Does connect to a running repl in your project work in v2.0.336?

@PEZ
Copy link
Collaborator

PEZ commented Mar 15, 2023

And, does ctrl+c work in 336? Thinking it could be this issue:

(Which does not have a solution yet.)

@cmaussan
Copy link
Author

cmaussan commented Mar 15, 2023

Thanks! Does connect to a running repl in your project work in v2.0.336?

Yes!

And, does ctrl+c work in 336? Thinking it could be this issue:

It works! (that's why I noticed it in 337)

@PEZ
Copy link
Collaborator

PEZ commented Mar 16, 2023

ctrl+c in pseudo terminal does not really kill the repl either. A ps launched in another terminal shows the repl still up.

Hi again! The connection issue should be fixed in 338. Can you check if this one still is left to fix?

@cmaussan
Copy link
Author

Hello!
Yes, the connection issue is fixed. But ctrl+c in the terminal still does not kill the repl.

@PEZ
Copy link
Collaborator

PEZ commented Mar 16, 2023

Thanks. We track it here now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jack-in regression Regression error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants