Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot start a cljs REPL since version 2.0.355 #2200

Closed
furkan3ayraktar opened this issue May 19, 2023 · 3 comments
Closed

Cannot start a cljs REPL since version 2.0.355 #2200

furkan3ayraktar opened this issue May 19, 2023 · 3 comments
Labels
bug Something isn't working cljs ClojureScript-related connect jack-in regression Regression error

Comments

@furkan3ayraktar
Copy link

The newer versions of Calva are reporting the following when I Jack-in:

Error while connecting cljs REPL: class clojure.lang.Compiler$CompilerException

As a result, I cannot use the cljs REPL.
I rolled back my Calva version one by one and discovered that the REPL works as expected on version 2.0.355.
Here are the related parts of the settings.json:

{...

  "calva.autoOpenJackInTerminal": true,
  "calva.autoConnectRepl": true,
  "calva.replConnectSequences": [
    {
      "projectType": "shadow-cljs",
      "name": "Start ShadowCLJS REPL",
      "autoSelectForJackIn": true,
      "projectRootPath": [
        "."
      ],
      "cljsType": "shadow-cljs",
      "menuSelections": {
        "cljsLaunchBuilds": [
          "frontend",
          "devcards",
          "test"
        ],
        "cljsDefaultBuild": "frontend"
      }
    },
    {
      "projectType": "deps.edn",
      "name": "Connect ShadowCLJS REPL",
      "autoSelectForConnect": true,
      "projectRootPath": [
        "."
      ],
      "cljsType": "shadow-cljs",
      "menuSelections": {
        "cljsDefaultBuild": "frontend"
      }
    }
  ],

...}

Shadow CLJS version: 2.20.12

@PEZ PEZ added bug Something isn't working jack-in connect regression Regression error cljs ClojureScript-related labels May 21, 2023
@PEZ
Copy link
Collaborator

PEZ commented May 21, 2023

Thanks. I can reproduce this. It seems to be related to a combination involving the connect sequences. If I set autoSelectForJackIn to false and choose shadow-cljs as project type, the connection works.

@PEZ
Copy link
Collaborator

PEZ commented May 21, 2023

Found it. We don't keywordize the builds with the new check for cljs runtimes. Your config starts to work if I prepend the builds with :, @furkan3ayraktar. Fix coming, but now you know how to dodge this bug.

@furkan3ayraktar
Copy link
Author

Great to hear you were able to find! Thank you and tack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cljs ClojureScript-related connect jack-in regression Regression error
Projects
None yet
Development

No branches or pull requests

2 participants