Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform about that Interrupt Evaluation does not awlays work on JVM 20+ #2324

Open
PEZ opened this issue Oct 8, 2023 · 0 comments
Open

Inform about that Interrupt Evaluation does not awlays work on JVM 20+ #2324

PEZ opened this issue Oct 8, 2023 · 0 comments
Labels
documentation Better documentation needed. evaluation nrepl upstream

Comments

@PEZ
Copy link
Collaborator

PEZ commented Oct 8, 2023 •
edited

With JVM 20, Thread.stop() was removed, making interrupting evaluations sometimes fail, because that's what nREPL falls back to, if Thread.interrupt() fails. See:

Calva could probably detect this failure somehow, and inform the user about it. Possibly linking to the nREPL issue, to get more people's brains on the problem.
@PEZ PEZ added documentation Better documentation needed. upstream evaluation nrepl labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Better documentation needed. evaluation nrepl upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ