Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPrint status bar button does not immediately update when config value changed in settings #358

Closed
bpringe opened this issue Sep 28, 2019 · 4 comments

Comments

@bpringe
Copy link
Contributor

@bpringe bpringe commented Sep 28, 2019

I'm addressing this now with a small change.

@PEZ

This comment has been minimized.

Copy link
Collaborator

@PEZ PEZ commented Oct 3, 2019

Not sure why it is not closing automatically. But this is now released.

@PEZ PEZ closed this Oct 3, 2019
@bpringe

This comment has been minimized.

Copy link
Contributor Author

@bpringe bpringe commented Oct 3, 2019

I wonder if it's because I'm only putting the "fixes" term in the PR description, and not in any commit message. The docs look like it should work just in the PR description though.

@dijonkitchen

This comment has been minimized.

Copy link
Contributor

@dijonkitchen dijonkitchen commented Oct 3, 2019

I think it's because it was merged into the dev branch instead of master?

@PEZ

This comment has been minimized.

Copy link
Collaborator

@PEZ PEZ commented Oct 3, 2019

It reached master without the issue being closed. I think it needs to be in a commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.