Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make code more robust in case Jack-in task fails. #367

Closed
cfehse opened this issue Oct 2, 2019 · 3 comments
Closed

[Enhancement] Make code more robust in case Jack-in task fails. #367

cfehse opened this issue Oct 2, 2019 · 3 comments

Comments

@cfehse
Copy link
Contributor

@cfehse cfehse commented Oct 2, 2019

The extension should behave more robust, if the Jack-in task fails either initially (e.g. the user selected an invalid project configuration like Leiningen + shadow-cljs if the project is only a Leiningen project) or the REPL process ends prematurely (e.g. a Leiningen project is only used for documentation generation and starting a REPL in the project will fail).
The extension should always return to a usable state - not leaving die UI in the connecting state with the nREPL button not usable.

@PEZ

This comment has been minimized.

Copy link
Collaborator

@PEZ PEZ commented Oct 2, 2019

Agree! Maybe this too:

The user should be able to abort the jack-in process at any prompt by pressing ESC. Today, for some of the prompts, Calva doesn't ”listen” to that and just continues. With bad results, since it doesn't have the answer from the prompt.

If this should be in an issue of its own, let me know and I'll file a new issue instead.

@cfehse

This comment has been minimized.

Copy link
Contributor Author

@cfehse cfehse commented Oct 3, 2019

@PEZ

Good point! For the first step in the connection sequence I corrected this already. But I will take a look at the following steps as well.

@cfehse

This comment has been minimized.

Copy link
Contributor Author

@cfehse cfehse commented Oct 11, 2019

This is fixed in version 2.0.47.

@cfehse cfehse closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.