Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove warning that extensions use the `vscode-resource:` scheme directly. #391

Closed
cfehse opened this issue Oct 11, 2019 · 1 comment
Closed

Comments

@cfehse
Copy link
Contributor

@cfehse cfehse commented Oct 11, 2019

Beginning with version 1.39 vscode creates a warning message if an extension uses the vscode-resource: directly (see Warn webview extensions that use the vscode-resource: scheme directly) .

The should be avoided by changing the dev dependency "vscode": "^1.1.34" to version 1.1.36 and use the vscode.Webview.asWebviewUri() where needed.

Edit:
The npm package vscode is no longer supported by the vscode project. The dependency must be change to "@types/vscode": "^1.30.0" which corresponds to the vscode property in the engines definition in package.json .

@cfehse cfehse mentioned this issue Oct 11, 2019
8 of 8 tasks complete
@cfehse

This comment has been minimized.

Copy link
Contributor Author

@cfehse cfehse commented Oct 12, 2019

This issue is fixed in version 2.0.49.

@cfehse cfehse closed this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.