Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-linting warnings about floating promises #411

Closed
sauvala opened this issue Oct 19, 2019 · 1 comment
Closed

TS-linting warnings about floating promises #411

sauvala opened this issue Oct 19, 2019 · 1 comment
Labels

Comments

@sauvala
Copy link
Contributor

@sauvala sauvala commented Oct 19, 2019

While I'm hacking Calva my ts-lister is showing warnings about floating promises on function calls of evaluateSelection in src/evaluate.ts.

Here is one of them

evaluateSelection(document, Object.assign({}, options, { replace: true, pprint: state.config().pprint }));

sauvala added a commit to sauvala/calva that referenced this issue Oct 19, 2019
sauvala added a commit to sauvala/calva that referenced this issue Oct 19, 2019
@sauvala sauvala mentioned this issue Oct 19, 2019
9 of 20 tasks complete
sauvala added a commit to sauvala/calva that referenced this issue Oct 26, 2019
@sauvala sauvala mentioned this issue Oct 26, 2019
9 of 20 tasks complete
@bpringe

This comment has been minimized.

Copy link
Contributor

@bpringe bpringe commented Oct 31, 2019

Closing since it appears the fix has been merged. Thanks @sauvala!

@bpringe bpringe closed this Oct 31, 2019
@bpringe bpringe added the evaluation label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.