Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated test runner does not show test message #425

Closed
stefan-toubia opened this issue Oct 24, 2019 · 2 comments
Closed

Integrated test runner does not show test message #425

stefan-toubia opened this issue Oct 24, 2019 · 2 comments
Labels

Comments

@stefan-toubia
Copy link
Contributor

clojure.test/is allows you to include a message in the test that would display in the test output if the test fails. This would be helpful to include in the Calva says output as well.

Example:

(testing "Test message"
      (is (= 1 2) "Math is hard"))

Calva says:

FAIL in: upload_helpers_test.clj: 21: create-s3-key-test: Test message:
  expected: 1

  actual: (2)

CircleCI:

FAIL in upload-helpers-test/ (create-s3-key-test) (upload_helpers_test.clj:21)
Test message
Math is hard
expected: 1
  actual: (2)
@PEZ
Copy link
Collaborator

PEZ commented Oct 24, 2019

Thanks! I think this should be fairly easy to fix. Please feel invited to have a look at it, if you have the time.

@dadair-ca
Copy link

Hi @PEZ! It looks like this issue has been resolved as of #470 (merged Nov 14, 2019).

Was just looking around at good first issues, but looks like this is done already!

Thanks for all your work on Calva! It's a great addition to the Clojure ecosystem.

@bpringe bpringe closed this as completed Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants