Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paredit/Editor] paredit.deleteBackward sets cursor position wrong when deleting a line. #458

Closed
cfehse opened this issue Nov 8, 2019 · 3 comments
Labels
bug Something isn't working paredit Paredit and structural editing

Comments

@cfehse
Copy link
Contributor

cfehse commented Nov 8, 2019

This behavior is a bit hard to describe: if the paredit in the editor is set to strict mode - [λ] - the backspace key executes the paredit.deleteBackward command. If the delete operation deletes a new line (deletes the line in the editor) the cursor position is set 1 character left from what it was before. The leads to a behavior like this if the user does not pay attention:

calva-paredit-delete-linebreak-nex-index

@PEZ
Copy link
Collaborator

PEZ commented Nov 8, 2019

Wow!

This should be fixed by us swapping out paredit.js for our own Paredit implementation. I have tried filing issues on paredit.js and there is no response.

@cfehse cfehse mentioned this issue Nov 8, 2019
19 tasks
@cfehse
Copy link
Contributor Author

cfehse commented Nov 8, 2019

@PEZ

I just quickly fixed it because this issue is very ugly I think. Changing the paredit implementation is a bit of a bigger task, isn't it? But it should definitely be done soon.

@PEZ
Copy link
Collaborator

PEZ commented Nov 8, 2019

Could be big. Could be small. 😄 I am starting to think it will not be very hard, now that we are starting to understand the token cursor and our own paredit module a bit. We will find out.

@cfehse cfehse added paredit Paredit and structural editing bug Something isn't working labels Nov 11, 2019
@PEZ PEZ closed this as completed in 5074718 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working paredit Paredit and structural editing
Projects
None yet
Development

No branches or pull requests

2 participants