Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Calva commands in editor context menu when editorLangId is not Clojure #615

Closed
bpringe opened this issue Apr 17, 2020 · 4 comments
Closed

Hide Calva commands in editor context menu when editorLangId is not Clojure #615

bpringe opened this issue Apr 17, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@bpringe
Copy link
Member

bpringe commented Apr 17, 2020

image

The above context menu was opened from a non-clojure file (.txt). We should use when clauses in the package.json menu contributions to not show these commands when the editor lang is not Clojure.

https://code.visualstudio.com/api/references/contribution-points#contributes.menus

See the docs for the difference in when and enablement.
@dadair-ca
Copy link

Hi! I was wondering if I could help out by taking this on as my first issue in Calva?

@bpringe
Copy link
Member Author

bpringe commented Apr 19, 2020

That would be great! Please see the wiki guide for how to hack on Calva.

@dadair-ca dadair-ca mentioned this issue Apr 19, 2020
Merged
18 tasks
@bpringe bpringe closed this as completed Apr 19, 2020
@PEZ
Copy link
Collaborator

PEZ commented Apr 20, 2020

I think this should stay open until it is merged onto master (released, that is).

@PEZ PEZ reopened this Apr 20, 2020
@bpringe
Copy link
Member Author

bpringe commented Apr 20, 2020

Got it! My bad.

@PEZ PEZ closed this as completed in 8b2116e Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PEZ @dadair-ca @bpringe