Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable active item in suggestion popup (REPL window) #623

Closed
zelark opened this issue Apr 24, 2020 · 2 comments
Closed

Unreadable active item in suggestion popup (REPL window) #623

zelark opened this issue Apr 24, 2020 · 2 comments

Comments

@zelark
Copy link
Contributor

zelark commented Apr 24, 2020

If one uses a light theme, an active item in suggestion menu is completely unreadable.
calva-repl-before

A local hack to fix it is to put it in settings.json

  "workbench.colorCustomizations": {    
    "list.activeSelectionBackground": "#d6ebff"
  }

calva-repl-after

To fix it globally I'd suggest to use editorSuggestWidget.selectedBackground and editorSuggestWidget.highlightForeground instead of list.activeSelectionBackground and list.highlightForeground respectively (webview.scss). Then it will work for both dark and light default themes

@PEZ
Copy link
Collaborator

PEZ commented Apr 24, 2020

Great suggestion! PR?

@zelark
Copy link
Contributor Author

zelark commented Apr 24, 2020

@PEZ Ok, I will do this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants