Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File lexing fails on junk characters inside strings, breaking Calva in that file #659

Closed
PEZ opened this issue Jun 5, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working parsing

Comments

@PEZ
Copy link
Collaborator

PEZ commented Jun 5, 2020

When there is some unrecognised character inside a string, the lexer croaks and then the token cursor can't be created which means that about all Calva functionality dies in that file.

Reproduction

Here what looks like a space inside the string, is really something else.

(def foo
  [" ("])

Since I don't know if the funny character gets pasted correctly, here's a zip: tiny.cljc.zip

Expected: Things should tick on as normal, Rainbow parens, evaluations, paredit, formatting.

Actual: All that breaks.

@PEZ PEZ added bug Something isn't working parsing labels Jun 5, 2020
@PEZ PEZ self-assigned this Jun 5, 2020
@PEZ PEZ closed this as completed in ce1d755 Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parsing
Projects
None yet
Development

No branches or pull requests

1 participant