Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover to display results for eval as window into output file #693

Closed
bpringe opened this issue Jul 27, 2020 · 1 comment
Closed

Add hover to display results for eval as window into output file #693

bpringe opened this issue Jul 27, 2020 · 1 comment

Comments

@bpringe
Copy link
Member

bpringe commented Jul 27, 2020

Instead of adding the results to the hover like we have done in the past, now that we print them to an output file, I believe we can add a hover for evaluations in files, that shows a window into the section of the output file where the results were printed.

This allows the user to see results without opening the results window.

If possible it would be nice to include links to open the results window (as happens currently), as well as copy all of the text of the result (as we had with the previous implementation of hover results).

@PEZ
Copy link
Collaborator

PEZ commented Jul 28, 2020

What could be within somewhat easy reach is if we can make a definition provider that is aware of the active evaluation annotations. Then holding down the command-key within the evaluation range, or pressing alt+f12 will display the relevant portion of the output file. And we could probably make a Copy button there as well that would pluck the result output range...

Relevant for this is also this upstream issue: microsoft/vscode#3220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants