Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back results in hovers #736

Closed
Yunfeng-Song opened this issue Aug 8, 2020 · 3 comments
Closed

Bring back results in hovers #736

Yunfeng-Song opened this issue Aug 8, 2020 · 3 comments

Comments

@Yunfeng-Song
Copy link

Yunfeng-Song commented Aug 8, 2020

I think it used to display a copy button and your inline evaluation result in a good format. I really really like this feature.

but I think this feature doesn't work now after the update. Now if I hove over, it just displays a button says Open results window. Now I have to switch to output-repl file every time I want to check a big result. So is it a bug or this hover over feature is gone forever?
image

PS: I know we can use peek to achieve the same thing, but I still think this hover over feature is better.

@Yunfeng-Song Yunfeng-Song changed the title Hover over result for inline evaluation Hover over result not working for inline evaluation Aug 8, 2020
@PEZ
Copy link
Collaborator

PEZ commented Aug 8, 2020

I didn't like the implementation and hurried to remove it once we had the output window displaying and making it easy to copy the results.

It was also my impression that this was not a very used feature. Which seems to have been a faulty assumption. You are not the first one to ask for it, if I put out that way.

We are considering if there is a more proper way to implement it, and even if we can live with the previous implementation.

Let's see if this issue attracts the fans of the feature. That would certainly help us prioritize and decide which way to go. Thanks for posting it!

@bpringe bpringe changed the title Hover over result not working for inline evaluation Bring back results in hovers Jan 3, 2021
@PEZ PEZ mentioned this issue Apr 18, 2021
12 tasks
@PEZ
Copy link
Collaborator

PEZ commented Apr 18, 2021

@Yunfeng-Song Please give this VSIX a spin: https://12955-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.189-736-result-hovers-cb6f42f1.vsix

@Yunfeng-Song
Copy link
Author

Looks ### ### good!****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants