Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getDocument function to not return a Log document #771

Closed
bpringe opened this issue Aug 28, 2020 · 0 comments
Closed

Fix getDocument function to not return a Log document #771

bpringe opened this issue Aug 28, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bpringe
Copy link
Member

bpringe commented Aug 28, 2020

This is located in src/utilities.ts. Currently if no editors are open, but the bottom pane is open with, for example, the Output -> Tasks pane showing, then the document returned from getDocument has a .uri.fsPath of tasks. This function should only return an editor whose document is an actual file.

This may be best accomplished by filtering visible text editors by languageId. (It's Log when the document.uri.fsPath is tasks.)

@bpringe bpringe added bug Something isn't working high priority and removed high priority labels Aug 28, 2020
@bpringe bpringe changed the title Fix getDocument function to not return a document from the bottom pane (Logs etc) Fix getDocument function to not return a Log document Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant